Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commented assertions #15770

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Remove commented assertions #15770

merged 1 commit into from
Dec 19, 2024

Conversation

asoliman92
Copy link
Contributor

No description provided.

@asoliman92 asoliman92 requested a review from a team as a code owner December 19, 2024 13:27
@asoliman92 asoliman92 requested a review from jmank88 December 19, 2024 13:27
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , GolangCI Lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , test-scripts , Flakeguard Deployment Project , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/ocr2/plugins/ccip/ccipexec, ubu... , lint , Flakeguard Root Project / Report , SonarQube Scan , Flakey Test Detection

1. GolangCI Lint errors

Error: Directory prefix does not contain main module

[job id where the error happened]: Golang Lint

Source of Error:
Golang Lint () 2024-12-19T13:29:09.6261344Z level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix / does not contain main module or its selected dependencies"

Why: This error occurs because the specified directory / does not contain the main Go module or its dependencies, which is required for type checking.

Suggested fix: Ensure that the working-directory is set to the correct path where the Go module is located. Update the working-directory input in the GitHub Action configuration to point to the directory containing the go.mod file.

Error: Permission denied for creating output file

[job id where the error happened]: Golang Lint

Source of Error:
Golang Lint () 2024-12-19T13:29:09.6262743Z level=error msg="Running error: can't create output for golangci-lint-report.xml: open golangci-lint-report.xml: permission denied"

Why: This error occurs because the action does not have the necessary permissions to create or write to the golangci-lint-report.xml file in the specified directory.

Suggested fix: Ensure that the action has write permissions to the directory where it is trying to create the golangci-lint-report.xml file. You may need to adjust the directory permissions or change the output directory to a location where the action has write access.

Error: No such file or directory

[job id where the error happened]: Golang Lint

Source of Error:
Golang Lint () 2024-12-19T13:29:09.6508941Z cat: .//golangci-lint-report.xml: No such file or directory

Why: This error occurs because the golangci-lint-report.xml file does not exist, likely due to the previous permission error preventing its creation.

Suggested fix: Fix the permission issue first to ensure the file can be created. Verify the file path and ensure the directory exists and is writable by the action.

@asoliman92 asoliman92 added this pull request to the merge queue Dec 19, 2024
Merged via the queue into develop with commit 99efd78 Dec 19, 2024
186 of 187 checks passed
@asoliman92 asoliman92 deleted the cleaning branch December 19, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants